[ 
https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477724#comment-16477724
 ] 

ASF GitHub Bot commented on TINKERPOP-1945:
-------------------------------------------

Github user danielcweber commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/842#discussion_r188698548
  
    --- Diff: 
gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs
 ---
    @@ -39,7 +39,13 @@ public class GraphSONReaderTests
             private GraphSONReader CreateStandardGraphSONReader()
             {
                 return new GraphSONReader();
    -            }
    +        }
    +
    +        [Fact]
    +        public void Assert_loaded_Newtonsoft_Json_version()
    +        {
    +            Assert.Equal(new Version(11, 0, 0, 0), 
typeof(JToken).Assembly.GetName().Version);
    --- End diff --
    
    I can remove it, but since it is still unclear what forces that 9.0.0 
reference, we might actually just leave it in and update it on a 
Newtonsoft.Json-update, it's easily done. It might be helpful in looking for 
the root cause for that 9.0.0 dependency and for future mishaps where the wrong 
version loads.


> Add support for extended GraphSon types to Gremlin.net
> ------------------------------------------------------
>
>                 Key: TINKERPOP-1945
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1945
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>            Reporter: Daniel C. Weber
>            Priority: Minor
>
> While Gremlin.net can properly serialize and deserialize all of the core 
> GraphSon types, support for most of the extended types as described 
> [here|[http://tinkerpop.apache.org/docs/3.3.2/dev/io/#_extended]] is lacking.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to