GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/870
TINKERPOP-1968 Refactor Gremlin Server integration test framework
https://issues.apache.org/jira/browse/TINKERPOP-1968
A number of things happened here:
* There is now only one test configuration for Gremlin Server covering all
testing purposes related to it (i.e integration tests, GLV tests, console tests)
* More GLV tests have been enabled which unfortunately created tests that
had to be ignored in some GLVs - issues in JIRA have been created
* We now have `TinkerFactory.createGratefulDead()` which was helpful for
testing
* There is now just one method for ignoring GLV tests in relation to
verification that all tests implemented as java tests are also implemented as
GLV test.
All tests pass with `docker/build.sh -t -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1968
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/870.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #870
----
commit 615d6ea7126c23325cbe7ed78a58c9102dd6649e
Author: Stephen Mallette <spmva@...>
Date: 2018-05-18T18:34:44Z
TINKERPOP-1968 Added edge ids to sink and grateful generator
Edge ids should have always been statically defined - not sure how/why that
was missed. Also added grateful dead dataset to TinkerFactory to make that
easier to programmatically setup.
commit d116ad5c4e5d7ddf829fa6db4c9566d949db87ef
Author: Stephen Mallette <spmva@...>
Date: 2018-05-18T18:38:04Z
TINKERPOP-1968 Simplified gremlin server test configuration
There was a fair bit of duplicated configuration for Gremlin Server testing
- streamlined that to a single gremlin-server-integration.yaml file and script
initializer. Tests had to become more specific as to the graphs that they were
executing against as a result.
commit 784e851fb0daa2ee7228d84d9ebac0b1c3feb132
Author: Stephen Mallette <spmva@...>
Date: 2018-05-18T18:39:53Z
TINKERPOP-1968 Enabled GLV tests for self loops
commit fe1ec47886b2d1aa2d8a99539026779f6d1e03b5
Author: Stephen Mallette <spmva@...>
Date: 2018-05-18T20:17:11Z
TINKERPOP-1968 Configured all the match() tests for GLV
These were ignored because grateful dead wasn't an available graph, buuuuut
it's been available for a while now so i'm not sure why those weren't setup.
commit 59c0ad0a51dba1050ca1610c92d6661a097b4e2d
Author: Stephen Mallette <spmva@...>
Date: 2018-05-18T22:39:39Z
TINKERPOP-1968 Minor change to loading Grateful from TinkerFactory
Decided to load it from a resources in tinkergraph-gremlin. Seemed to
better than relying on the local file system.
commit d9c462ee335396af633f865a0803d70281d23e8f
Author: Stephen Mallette <spmva@...>
Date: 2018-05-19T11:16:09Z
TINKERPOP-1968 Make Pop tests more GLV friendly
The java/groovy tests were nicer before, but they don't translate to GLV
tests well. Had to change them to get them off the ignore list.
commit 172973263ea34fc10935ecf77badef3691b03399
Author: Stephen Mallette <spmva@...>
Date: 2018-05-19T11:57:07Z
TINKERPOP-1968 Stop ignoring test that passes for python GLV
commit c42b8b678ba4b09cb7c927d4051cb89ded2c9dd6
Author: Stephen Mallette <spmva@...>
Date: 2018-05-21T10:57:36Z
TINKERPOP-1968 Embedded list tests only pass for js at this point
Creating issues for .net and python.
commit 88f54f237d6c733a05694f2fb587defd6ed1278a
Author: Stephen Mallette <spmva@...>
Date: 2018-05-21T11:06:35Z
TINKERPOP-1968 PageRank tests aren't currently part of the required tests
commit 5c2a94fe672f0355a9bde358d11a5affaaaa8a78
Author: Stephen Mallette <spmva@...>
Date: 2018-05-21T11:07:20Z
TINKERPOP-1968 Removed embedded list test from ignored validation
commit cf257840a43f4b180d789321f3a2b4e7a2d77c50
Author: Stephen Mallette <spmva@...>
Date: 2018-05-21T11:46:07Z
TINKERPOP-1968 Have one method of ignoring tests.
Tests that should be ignored are "unsupported" in the .feature files. The
validator doesn't need a second level of filtering for that.
commit ffe96b2ea44e361d2891631b4c426510d3085730
Author: Stephen Mallette <spmva@...>
Date: 2018-05-21T12:32:03Z
TINKERPOP-1968 Open up a formerly ignored test
commit b6a8f737cb4acdbb4ee6504094d11727e25d1564
Author: Stephen Mallette <spmva@...>
Date: 2018-05-21T12:56:15Z
TINKERPOP-1968 Javascript doesn't handle embedded list assertions.
Had to ignore this test for now.
----
---
