[ 
https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509802#comment-16509802
 ] 

ASF GitHub Bot commented on TINKERPOP-967:
------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/876
  
    @GCHQResearcher1337  I should have also added in my last comment:
    
    1. Please add [CHANGELOG 
](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc) entries 
as necessary to 3.4.0
    2. This feature is sufficiently interesting that it probably deserves some 
special attention. Do you mind writing up something to introduce this change to 
users in the [Upgrade 
Documentation](https://github.com/apache/tinkerpop/blob/master/docs/src/upgrade/release-3.4.x.asciidoc)
 for 3.4.0. 
    
    If you like, I can handle the upgrade docs for you when we go to merge. 
Just let me know how you'd like to proceed.


> Support nested-repeat() structures
> ----------------------------------
>
>                 Key: TINKERPOP-967
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-967
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.1.0-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>            Priority: Major
>
> All the internal plumbing is staged for this to happen, we just haven't gone 
> all the way. In short, a {{NESTED_LOOP}} traverser has an internal 
> {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two. 
> The {{it.loops()}} checks of the internal repeat will always check the top of 
> the stack and when its done repeating will delete its counter off the top of 
> the stack.
> [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In 
> {{RepeatStep}} we will support:
> {code}
> repeat('a',out('knows').repeat('b',out('parent')))
> {code}
> and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that 
> naming the loop stack will be a super rare case as most people will just 
> assume standard nested looping semantics with a push/pop stack.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to