[ 
https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512740#comment-16512740
 ] 

ASF GitHub Bot commented on TINKERPOP-1822:
-------------------------------------------

Github user krlohnes commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/838#discussion_r195496700
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
 ---
    @@ -273,11 +300,40 @@ public RepeatEndStep(final Traversal.Admin traversal) 
{
                 super(traversal);
             }
     
    +        final LinkedList<Traverser.Admin<S>> stashedStarts = new 
LinkedList<>();
    --- End diff --
    
    @spmallette Any thoughts on what might be some decent data/traversals for 
the JFRs/microbenchmarks around this? 
    
    As far as OLAP goes, what are the expectations there? I haven't made any 
code changes to the computer algorithm yet since I'm not terribly familiar with 
that side of TinkerPop, so I think things should still be working working as 
before. I guess the question here is code changes or documentation changes when 
it comes to OLAP? 
    
    I'm hopefully going to spend some time this weekend or the next around this.


> Repeat should depth first search
> --------------------------------
>
>                 Key: TINKERPOP-1822
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1822
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.3.0, 3.2.6
>            Reporter: Robert Dale
>            Priority: Major
>
> Perhaps optionally.
> See also:
> * https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE
> * https://github.com/apache/tinkerpop/pull/715



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to