[
https://issues.apache.org/jira/browse/TINKERPOP-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551072#comment-16551072
]
ASF GitHub Bot commented on TINKERPOP-2011:
-------------------------------------------
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/894
Code & tests LGTM.
VOTE: +1
> Use NumberHelper on choose()
> ----------------------------
>
> Key: TINKERPOP-2011
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2011
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.9
> Reporter: stephen mallette
> Assignee: Daniel Kuppitz
> Priority: Minor
>
> The {{choose()} step could use {{NumberHelper}} to make this easier:
> {code}
> gremlin> g.V(1).choose(values('b')).option(b,
> constant(true)).option(none,constant(false))
> ==>true
> gremlin> g.V(1).choose(values('b')).option(1,
> constant(true)).option(none,constant(false))
> ==>false
> gremlin> g.V(1).choose(values('b')).option(1 as byte,
> constant(true)).option(none,constant(false))
> ==>true
> {code}
> as discussed here:
> https://groups.google.com/d/msg/gremlin-users/4pjH7AOM72s/ohIEdABfBQAJ
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
