[ 
https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566666#comment-16566666
 ] 

ASF GitHub Bot commented on TINKERPOP-1990:
-------------------------------------------

Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/882#discussion_r207197353
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java
 ---
    @@ -2451,6 +2452,24 @@ else if (value instanceof Traversal)
             return this.asAdmin().addStep((Step<E, E>) new 
PeerPressureVertexProgramStep(this.asAdmin()));
         }
     
    +    /**
    +     * Executes a Shortest Path algorithm over the graph.
    +     *
    +     * @return the traversal with the appended {@link 
ShortestPathVertexProgramStep}
    +     * @see <a 
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#shortestpath-step";
 target="_blank">Reference Documentation - ShortestPath Step</a>
    +     */
    +    public default GraphTraversal<S, Path> shortestPath() {
    +        if (this.asAdmin().getEndStep() instanceof GraphStep) {
    --- End diff --
    
    So, what does this mean exactly? Like, if you did 
`g.V().has('name','marko')` it wouldn't filter "marko" vertex without you 
throwing an `identity()` in there?


> Add a shortestPath() step
> -------------------------
>
>                 Key: TINKERPOP-1990
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1990
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>            Priority: Major
>
> Implement {{ShortestPathVertexProgram}} and a {{shortestPath()}} step.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to