[
https://issues.apache.org/jira/browse/TINKERPOP-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570185#comment-16570185
]
ASF GitHub Bot commented on TINKERPOP-2017:
-------------------------------------------
GitHub user yura-ata opened a pull request:
https://github.com/apache/tinkerpop/pull/908
TINKERPOP-2017 Add check for Column in `by(Function)`
https://issues.apache.org/jira/browse/TINKERPOP-2017
Minor change to check for `Column` in `by(Function)`
Excuse me if I've missed something: test (it was difficult to come up with
a test for this because only internal representation of traversal was changed),
changelog update, etc.) - would appreciate any guidance :)
Nevertheless, `mvn clean install` passes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yura-ata/tinkerpop
internal/TINKERPOP-2017_Column_in_by()
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/908.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #908
----
commit 5d9bdd0399507f51ea3ec0e2a3327942ab853c53
Author: yatam <yurii.atamanchuk@...>
Date: 2018-08-06T12:57:06Z
Add check for Column in `by(Function)`
----
> Check for Column in by()
> ------------------------
>
> Key: TINKERPOP-2017
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2017
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.9
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
>
> The {{by(Function)}} doesn't check for {{Column}}:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L57
> as it does here:
> https://github.com/apache/tinkerpop/blob/a14cf28f45742f47f15b768a90355ca9e9e89e17/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ByModulating.java#L94
> Seems like it would be better to just add:
> {code}
> if (function instanceof Column)
> this.modulateBy(new ColumnTraversal((Column) function))
> {code}
> Mentioned here on the user list:
> https://groups.google.com/d/msg/gremlin-users/Y0fez_aLdqs/nyUKQkO_AAAJ
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
