[
https://issues.apache.org/jira/browse/TINKERPOP-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573375#comment-16573375
]
ASF GitHub Bot commented on TINKERPOP-1976:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/909
Tinkerpop 1976
https://issues.apache.org/jira/browse/TINKERPOP-1976
Added GLV tests for `pageRank()` and `peerPressure()` (i.e. "computer"
tests). Apparently we had good support for this already in the GLVs (except
gremlin-javascript - which will need that support added). Got rid of some
remote test `OptOut` declarations too.
All tests pass with `docker/build.sh -t -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1976
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 9cb6204824aa43b9a835fcf4a985d983f01821d1
Author: Stephen Mallette <spmva@...>
Date: 2018-08-02T23:44:50Z
TINKERPOP-1976 Removed some OptOuts on RemoteGraph
Some tests needed to use the "process" runner apparently
commit bdcdaa7bb59f4d365fd89e99ddb0b1b64aa86b62
Author: Stephen Mallette <spmva@...>
Date: 2018-08-04T10:01:53Z
TINKERPOP-1976 Minor refactoring and test message improvement
commit dc95de4899c185f03c97db9670638301d00fd2bc
Author: Stephen Mallette <spmva@...>
Date: 2018-08-06T19:10:52Z
TINKERPOP-1976 Removed an OptOut from RemoteGraph
Carved out a special case for a behavior that is specific to remote
operations around side-effects
commit 44ab592c608bcc456ef5c152c53e3a8ecf790fcb
Author: Stephen Mallette <spmva@...>
Date: 2018-08-07T12:53:32Z
TINKERPOP-1976 Added pageRank() test for GLVs
commit 1414adc769b30b3ca61a1faef9db2cb551c2de55
Author: Stephen Mallette <spmva@...>
Date: 2018-08-07T17:45:39Z
TINKERPOP-1976 Added GLV test for peerPressure()
commit 3e432d0ffae919e4460af19301c6f8ca7ff6c61a
Author: Stephen Mallette <spmva@...>
Date: 2018-08-08T10:38:21Z
TINKERPOP-1976 Can't assert order() for pageRank()
----
> Include Computer tests for GLVs
> -------------------------------
>
> Key: TINKERPOP-1976
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1976
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.2.9
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Major
>
> I'm not clear as to why at this point, but we exclude tests that require a
> {{GraphComputer}} from GLV testing. It would be good to rectify that so that
> we can be assured that GLVs can properly handle steps that have that
> requirement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
