GitHub user justinchuch opened a pull request:
https://github.com/apache/tinkerpop/pull/916
Update comments in GraphProvider clear() and openTestGraph()
What's changed:
Classes that have implemented `GraphProvider#clear` must note that the
parameter `graph` and `config` are nullable, so that a proper `null` checking
and handling is needed. Otherwise, test cases that have extended
`org.apache.tinkerpop.gremlin.AbstractGremlinTest.java` may throw exception
when it comes to `tearDown()`
* Update comments in `GraphProvider#clear`, `GraphProvider#openTestGraph`.
* Add `null` checking in the `clear` method of the two implemented
`GraphProvider`:
- `org.apache.tinkerpop.gremlin.util.TinkerGraphProvider.java`
- `org.apache.tinkerpop.gremlin.tinkergraph.TinkerGraphProvider.java`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinchuch/tinkerpop
graphprovider-clear-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/916.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #916
----
commit de04c6432ef6669eaa299e4fb0bdce4d8b267c7d
Author: Justin Chu <15710241+justinchuch@...>
Date: 2018-08-16T23:44:32Z
Add null checking for configuration
commit 0894fd0b51b2ab5634af6ff8282450f6e185a43b
Author: Justin Chu <15710241+justinchuch@...>
Date: 2018-08-16T23:45:17Z
Update javadoc comments for clear method
----
---
