[
https://issues.apache.org/jira/browse/TINKERPOP-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette updated TINKERPOP-2033:
----------------------------------------
Description:
The {{annotations}} of {{ImmutableMetrics}} uses a {{ConcurrentHashMap}} but
that of course loses the insertion order. Convert to a {{synchronizedMap}} that
takes a {{LinkedHashMap}} to maintain that order as well as the ability to
support concurrent access which is an issue for some graphs.
This is a breaking change on Gryo 1.0 because there was no abstraction for
"metrics" class serialization in Gryo for that version. Any sort of change to
the object model would cause a break. Upgrade docs will discuss the upgrade
options.
was:
The {{annotations}} of {{ImmutableMetrics}} uses a {{ConcurrentHashMap}} but
that of course loses the insertion order. Convert to a {{synchronizedMap}} that
takes a {{LinkedHashMap}} to maintain that order as well as the ability to
support concurrent access which is an issue for some graphs.
This is a breaking change on Gryo 1.0 because {{synchronizedMap}} has to be
added as a type to Gryo and older versions of the driver will not support that
- therefore a user utilizing a driver prior to 3.2.10,3.3.4,3.4.0 won't be able
to return the result of {{profile()}} from a server running 3.4.0 with Gryo
1.0. The user would have to use one of those versions of the driver OR upgrade
3.3.x/3.4.0 and Gryo 3.0 (where {{Metrics}} serder is abstracted.
> Maintain order of profile() annotations
> ---------------------------------------
>
> Key: TINKERPOP-2033
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2033
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.4.0
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Labels: breaking
> Fix For: 3.4.0
>
>
> The {{annotations}} of {{ImmutableMetrics}} uses a {{ConcurrentHashMap}} but
> that of course loses the insertion order. Convert to a {{synchronizedMap}}
> that takes a {{LinkedHashMap}} to maintain that order as well as the ability
> to support concurrent access which is an issue for some graphs.
> This is a breaking change on Gryo 1.0 because there was no abstraction for
> "metrics" class serialization in Gryo for that version. Any sort of change to
> the object model would cause a break. Upgrade docs will discuss the upgrade
> options.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
