Github user justinchuch commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/934#discussion_r219678394
  
    --- Diff: 
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GroovyTranslator.java
 ---
    @@ -115,7 +116,8 @@ else if (object instanceof Bytecode)
             else if (object instanceof Traversal)
                 return convertToString(((Traversal) 
object).asAdmin().getBytecode());
             else if (object instanceof String) {
    -            return (((String) object).contains("\"") ? "\"\"\"" + object + 
"\"\"\"" : "\"" + object + "\"").replace("$", "\\$");
    +            return (((String) object).contains("\"") ? "\"\"\"" + 
StringEscapeUtils.escapeJava((String) object) + "\"\"\"" : "\"" + 
StringEscapeUtils.escapeJava((String) object) + "\"")
    +                    .replace("$", "\\$");
    --- End diff --
    
    The final `replace("$", "\\$")` has to be preserved or else some other 
original tests will be failed.


---

Reply via email to