[ 
https://issues.apache.org/jira/browse/TINKERPOP-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665337#comment-16665337
 ] 

Florian Hockmann commented on TINKERPOP-2074:
---------------------------------------------

The fix was really trivial, so I pushed it with a CTR commit. I only had to 
replace the {{*}} with {{${project.version\}}} in the command from the 
description:
[7445d18b05791e210c5d2682d7893ee4d47edb0a|https://github.com/apache/tinkerpop/commit/7445d18b05791e210c5d2682d7893ee4d47edb0a]

I also tested the change locally by changing the deployment target from 
nuget.org to a file path:

{code:sh}
[exec] Pushing Gremlin.Net.3.3.5-SNAPSHOT.nupkg to '/tmp/nuget'...
[exec] Your package was pushed.
[exec] Pushing Gremlin.Net.Template.3.3.5-SNAPSHOT.nupkg to '/tmp/nuget'...
[exec] Your package was pushed.
{code}

Since I also had packages for 3.4.0-SNAPSHOT ready, the fix seems to work as 
nuget.exe didn't try to also push them.

> Ensure that only NuGet packages for the current version are pushed
> ------------------------------------------------------------------
>
>                 Key: TINKERPOP-2074
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2074
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: build-release, dotnet
>            Reporter: Florian Hockmann
>            Priority: Minor
>             Fix For: 3.4.0, 3.3.5
>
>
> We currently use this command to push the NuGet packages to nuget.org:
> {code}
> ${nugetExe} push Gremlin.Net/bin/Gremlin.Net.*.nupkg [...]{code}
> which will push all versions of the package it can find in the 
> {{Gremlin.Net/bin}} directory. The same applies to the Gremlin.Net.Template.
> We should use the exact version here instead to avoid pushing packages for 
> any other versions by accident.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to