[
https://issues.apache.org/jira/browse/TINKERPOP-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670604#comment-16670604
]
ASF GitHub Bot commented on TINKERPOP-2072:
-------------------------------------------
spmallette opened a new pull request #982: TINKERPOP-2072 Refactored
TypeTranslator for direction extension
URL: https://github.com/apache/tinkerpop/pull/982
https://issues.apache.org/jira/browse/TINKERPOP-2072
This approach makes it much easier to extend `TypeTranslator` as the core
functionality of the `GroovyTranslator` is itself a `TypeTranslator`. Simply
extend that and go. Probably should have been this way from the beginning. This
is a breaking change but on a fairly hidden/internal component - should only
affect providers.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor custom type translation for ScriptTranslators
> ------------------------------------------------------
>
> Key: TINKERPOP-2072
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2072
> Project: TinkerPop
> Issue Type: Improvement
> Components: groovy
> Affects Versions: 3.3.4
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Major
> Labels: breaking
>
> Refactor the `TypeTranslator` system a bit so that it is better designed for
> extension rather than the "plugin" style system that exists now. The current
> method seems to work but it's a bit awkward in that it introduces some
> circular logic if a custom translator needs to refer back to the default one.
> In the worst case it means embedding {{GroovyTranslator}} itself in the
> {{TypeTranslator}}.
> Anyway, this is a breaking change because it completely alters the old method
> for handling this. On the plus side, this is a very low-level and internal
> feature that is only of interest to graph providers so it shouldn't break too
> much code out there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
