[
https://issues.apache.org/jira/browse/TINKERPOP-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681725#comment-16681725
]
ASF GitHub Bot commented on TINKERPOP-2079:
-------------------------------------------
spmallette opened a new pull request #992: TINKERPOP-2079 Moved RemoteGraph to
gremlin-test
URL: https://github.com/apache/tinkerpop/pull/992
https://issues.apache.org/jira/browse/TINKERPOP-2079
This is a breaking change as it removes the long deprecated `RemoteGraph`
from gremlin-core. Users should not have been using this at this point, so the
impact should be fairly limited. `RemoteGraph` is still needed as a test
component because we need a Graph instance for the JVM test suite to run
properly. This change required some refactoring as well in the
`RemoteGraphProvider` so that configurations were being passed around properly
to allow for the test suite to re-attach elements. That's yet another problem
with the JVM test suite - it unfortunately assumes embedded Graph assertions.
All tests pass with `docker/build.sh -t -i`
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Move RemoteGraph to test package
> --------------------------------
>
> Key: TINKERPOP-2079
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2079
> Project: TinkerPop
> Issue Type: Improvement
> Components: structure, test-suite
> Affects Versions: 3.4.0
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Major
> Labels: breaking
>
> With TINKERPOP-2078 {{RemoteGraph}} can become a test-only class. It can't be
> removed completely because of what the test infrastructure requires to run
> the suite, but it no longer needs to be publicly available. It's been
> deprecated a long time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
