I skimmed over the docs and they look good. I really like the new structure and the added sections :-) I only noticed one small issue: The Python tabs are empty for the first two code listings in Basic Gremlin: http://tinkerpop.apache.org/docs/3.4.0/reference/#basic-gremlin
No idea what's going on there as the code examples for Python are definitely in the AsciiDoc file. I also tried to validate the distribution. Everything worked until it builds the project and executes tests which unfortunately fails on my system, probably because a test assumes that the installed locale is en_US. I'm getting this failure with my de_DE locale: /java.text.ParseException: Unparseable date: "Jan 12, 1952"// // at org.apache.tinkerpop.gremlin.driver.ser.binary.GraphBinaryReaderWriterRoundTripTest.input(GraphBinaryReaderWriterRoundTripTest.java:156)/ The german representation of this date would be 12.01.1952 and other locales will again have different formats. We should change this test to work independently of the locally installed locale, but we can do that any time after the release. These two issues are really minor and shouldn't stop the release in my opinion, so: VOTE +1 Am 04.01.2019 um 23:33 schrieb Stephen Mallette: > <sigh> sorry....the template is just broken. I'll make a note to fix that. > > The tag in Apache Git can be found here: > https://github.com/apache/tinkerpop/tree/3.4.0 > > The release notes are available here: > https://github.com/apache/tinkerpop/blob/3.4.0/CHANGELOG.asciidoc > > > > On Fri, Jan 4, 2019 at 4:52 PM Robert Dale <[email protected]> wrote: > >> Some links point to 3.3.4 instead of 3.4.0. >> >> Robert Dale >> >> >> On Fri, Jan 4, 2019 at 4:51 PM Stephen Mallette <[email protected]> >> wrote: >> >>> Hello, >>> >>> We are happy to announce that TinkerPop 3.4.0 is ready for release. >>> >>> The release artifacts can be found at this location: >>> https://dist.apache.org/repos/dist/dev/tinkerpop/3.4.0/ >>> >>> The source distribution is provided by: >>> apache-tinkerpop-3.4.0-src.zip >>> >>> Two binary distributions are provided for user convenience: >>> apache-tinkerpop-gremlin-console-3.4.0-bin.zip >>> apache-tinkerpop-gremlin-server-3.4.0-bin.zip >>> >>> The GPG key used to sign the release artifacts is available at: >>> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS >>> >>> The online docs can be found here: >>> http://tinkerpop.apache.org/docs/3.4.0/ (user docs) >>> http://tinkerpop.apache.org/docs/3.4.0/upgrade/ (upgrade docs) >>> http://tinkerpop.apache.org/javadocs/3.4.0/core/ (core javadoc) >>> http://tinkerpop.apache.org/javadocs/3.4.0/full/ (full javadoc) >>> >>> The tag in Apache Git can be found here: >>> https://github.com/apache/tinkerpop/tree/3.3.4 >>> >>> The release notes are available here: >>> >> https://github.com/apache/tinkerpop/blob/3.3.4/CHANGELOG.asciidoc >>> The [VOTE] will be open for the next 72 hours --- closing Monday (January >>> 7, 2019) at 5:00pm EST. >>> >>> My vote is +1. >>> >>> Thank you very much, >>> >>> Stephen >>>
