Other than the few minor comments I made, I think this looks good. You have 
100% coverage on the new strategy which is cool. I can't help thinking that 
there is yet some case that hasn't be covered but I'm not sure what case of 
significance isn't in your tests already.  

Only thing I could think of was maybe a test or two that has the `range()` as 
an inner traversal? not sure I noticed that in your set of tests and it 
wouldn't offer any additional coverage, but perhaps it still has value?

I think it's worth mentioning this strategy in the upgrade docs and explaining 
its value.

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to