[
https://issues.apache.org/jira/browse/TINKERPOP-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771171#comment-16771171
]
ASF GitHub Bot commented on TINKERPOP-2161:
-------------------------------------------
jorgebay commented on pull request #1065: TINKERPOP-2161 - GraphBinary: use a
single buffer instead of allocators
URL: https://github.com/apache/tinkerpop/pull/1065
Improve write path by reusing the same buffer.
For serializers this is an API change but given that GraphBinary was
introduced recently, I think we can get away with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GraphBinary: Write serialization performance issue
> ---------------------------------------------------
>
> Key: TINKERPOP-2161
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2161
> Project: TinkerPop
> Issue Type: Bug
> Components: io
> Affects Versions: 3.4.0
> Reporter: Jorge Bay
> Priority: Major
>
> There seems to be a performance issue regarding the write path in GraphBinary:
> {code}
> Benchmark Mode Cnt Score
> Error Units
> SerializationBenchmark.testReadMessage1Binary thrpt 20 4800832.981 ±
> 430909.102 ops/s
> SerializationBenchmark.testReadMessage1GraphSON thrpt 20 34109.669 ±
> 5231.210 ops/s
> SerializationBenchmark.testReadMessage2Binary thrpt 20 827266.707 ±
> 78214.379 ops/s
> SerializationBenchmark.testReadMessage2GraphSON thrpt 20 18462.919 ±
> 2640.093 ops/s
> SerializationBenchmark.testWriteBytecodeBinary thrpt 20 130486.109 ±
> 5505.113 ops/s
> SerializationBenchmark.testWriteBytecodeGraphSON thrpt 20 592658.686 ±
> 68063.966 ops/s
> SerializationBenchmark.testWriteResponseBinary thrpt 20 290240.715 ±
> 25620.656 ops/s
> SerializationBenchmark.testWriteResponseGraphSON thrpt 20 612832.036 ±
> 48173.673 ops/s
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
