[
https://issues.apache.org/jira/browse/TINKERPOP-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776035#comment-16776035
]
ASF GitHub Bot commented on TINKERPOP-2143:
-------------------------------------------
fdominik commented on pull request #1070: TINKERPOP-2143 JavaScript GLV:
Support browsers
URL: https://github.com/apache/tinkerpop/pull/1070
https://issues.apache.org/jira/browse/TINKERPOP-2143
Summary of changes:
* Updated dependency on WS package (which was very old 3.0.0) to v 6.0.0.
This is required by browsers.
* Added dependency to util and events packages which were required by the
javascript module, but were not listed in dependencies, so that it wouldn't
compile.
* Added new dependency to uiid library.
* Generation of UUIDs was passed to UUID library instead of utilizing crypto
package (which is not anymore available as separate library in browsers world,
it is bundled, however some functions used in generating UUID were not
available in the new bundled crypto). The uuid library can generate UUID of
version 4, which was the version used to generate the UUIDs.
* Usage of standard WebSocket object from default packages.
- a new Buffer handling had to be written because the browser WS library
doesnt have automatic creation of Buffer Arrays, so it had to be implemented
from scratch => using Uint8Array.
Code has been tested in our UI project, where we can send requests from UI
to Gremlin server. I wasn't able to run the Tinkerpop tests locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> JavaScript GLV: Support browsers
> --------------------------------
>
> Key: TINKERPOP-2143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2143
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Reporter: Jorge Bay
> Priority: Minor
> Attachments: query-editor.jpg
>
>
> Currently the JavaScript GLV is designed to work on Node.js runtime.
> We could consider supporting browser runtimes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
