@fdominik - sorry it took me some time to come back to this. if the problem is 
with `package.json` then i think it's likely that your problem is related to 
the fact that we generate `package.json` from:

https://github.com/apache/tinkerpop/blob/3c87b3a99b5182b9c1dc245d474def1662bae68f/gremlin-javascript/glv/PackageJson.template

That generation is triggered by a maven command so that's probably why maven 
builds in Travis are having trouble. Hopefully, that solves your problem. 

As far as other issues go, I'll largely defer to @jorgebay and @jbmusso but I 
think that administratively, it would be nice to have an entry added in 
CHANGELOG for 3.4.1:

https://github.com/apache/tinkerpop/blob/3c87b3a99b5182b9c1dc245d474def1662bae68f/CHANGELOG.asciidoc

and if you want to really polish this up, then you would want to add a section 
to our "Upgrade Documentation":

https://github.com/apache/tinkerpop/blob/3c87b3a99b5182b9c1dc245d474def1662bae68f/docs/src/upgrade/release-3.4.x.asciidoc

specifically, a subsection to an "Upgrading for Users" for 3.4.1. This change 
seems interesting enough that users would want to know about it.

anyway, let's see if your build problem gets resolved on Travis and then we can 
resume the review process.






[ Full content available at: https://github.com/apache/tinkerpop/pull/1070 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to