I think it would make sense to use a different env var here instead of 
`TINKERPOP_DOCKER_OPTS`. My `TINKERPOP_DOCKER_OPTS` looks like this:

```bash
$ echo $TINKERPOP_DOCKER_OPTS
--tmpfs /usr/src/tinkermem:exec,mode=0755,rw,noatime,size=2000m -p 8080:80
```

The port mapping is necessary on Windows to be able to access the generated 
docs on Windows as Docker for Windows unfortunately doesn't support connecting 
to a Docker container via its IP.
This also means that I have to overwrite this env var now to:

```bash
TINKERPOP_DOCKER_OPTS="-p 45940:45940"
```

to get the integration tests working with this image.

If we would use a different env var here, then I (and possibly other 
contributors with Windows machines) could use this script and also still our 
usual `docker/build.sh` script :)

[ Full content available at: https://github.com/apache/tinkerpop/pull/1075 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to