[
https://issues.apache.org/jira/browse/TINKERPOP-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795370#comment-16795370
]
ASF GitHub Bot commented on TINKERPOP-2179:
-------------------------------------------
newkek commented on pull request #1084: TINKERPOP-2179: Have
SerializationException extend IOException [master]
URL: https://github.com/apache/tinkerpop/pull/1084
Same as #1083 but with some minor changes to some errors thrown in the
GraphBinary serialization.
I did a `merge -s ours` of the branch `TINKERPOP-2179` to this branch first
and then added another commit
https://github.com/apache/tinkerpop/commit/00954a92fec41eb19626f050585ad1f300dbd9bf.
A merge without the `-s ours` was causing conflicts in all the pom.xml for
some reason?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Have o.a.t.g.driver.ser.SerializationException extend IOException
> -----------------------------------------------------------------
>
> Key: TINKERPOP-2179
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2179
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.3.5
> Reporter: Kevin Gallardo
> Priority: Major
>
> Suggestion to have the SerializationException from gremlin extend Java's
> IOException. Some other libraries like Jackson do it.
> In Java 8 there is a new {{UncheckedIOException()}} that can be created and
> thrown at runtime, except it requires the underlying exception to be an
> IOException.
> Ideally if SerializationException extended IOException we could do something
> like:
> {code:java}
> try {
> GraphBinaryWriter.write(object, bytebuf);
> } catch (IOException e) {
> throw new UncheckedIOException("Could not serialize", e)
> }
> {code}
> So that the calling code does not throw a checked exception anymore. Also
> being able to catch IOException there would allow to be more generic.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
