Such an old issue - nice to see it with a chance at closing. I think that your proposal makes sense. Should we be expecting a neo4j version upgrade given the PR you submitted to neo4j-tinkerpop-api-impl? If so, note that an attempt was made already at a version upgrade on this:
https://github.com/apache/tinkerpop/pull/1042 not sure if it's easy to bring that change in too? If there is to be an upgrade, I think it should target 3.5.0 and the master branch. On Tue, Jun 25, 2019 at 10:20 AM Dmitry Novikov <[email protected]> wrote: > Hello, > > I've created this PR[1] in `neo4j-tinkerpop-api-impl`. Let's discuss it > here. > > If lists are converted to arrays on saving, for consistency arrays should > be converted to lists on loading. Therefore by supporting > `UniformListValues` Graph Feature, all of `*ArrayValues` Features becomes > unsupported. So it makes sense to make this configurable. > > My suggestion is to introduce `gremlin.neo4j.conf.convertArraysToLists` > configuration property and pass it to `neo4j-tinkerpop-api-impl`. > Configuration property will also require handling in `neo4j-gremlin` to > provide correct `Graph#features`. > > Is this correct way to achieve this from TinkerPop perspective? > > Regards, > Dmitry > > [1]: https://github.com/neo4j-contrib/neo4j-tinkerpop-api-impl/pull/15 > > On 2019/06/21 12:14:00, "stephen mallette (JIRA)" <[email protected]> > wrote: > > > > [ > https://issues.apache.org/jira/browse/TINKERPOP-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869433#comment-16869433 > ] > > > > stephen mallette commented on TINKERPOP-21: > > ------------------------------------------- > > > > Looks like someone just submitted a PR to {{neo4j-tinkerpop-api-impl}} > to implement this at a lower level - I guess we'd get that for free if it > merges: > > > > https://github.com/neo4j-contrib/neo4j-tinkerpop-api-impl/pull/15 > > > > > Auto-List Conversion Configuration for Neo4j > > > -------------------------------------------- > > > > > > Key: TINKERPOP-21 > > > URL: > https://issues.apache.org/jira/browse/TINKERPOP-21 > > > Project: TinkerPop > > > Issue Type: Improvement > > > Components: neo4j > > > Affects Versions: 3.0.2-incubating > > > Reporter: stephen mallette > > > Priority: Trivial > > > > > > Provide a configuration to Neo4j that enables a {{List}} to be > converted to a primitive array of that type. It worked that way by default > in TP2. > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v7.6.3#76005) > > >
