[
https://issues.apache.org/jira/browse/TINKERPOP-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877701#comment-16877701
]
Florian Hockmann commented on TINKERPOP-2253:
---------------------------------------------
Any reason why Gremlin.Net.CosmosDb uses {{JToken}} instead of letting
Gremlin.Net perform the deserialization completely? It looks to me like it
deserializes from {{JToken}} itself
[here|https://github.com/evo-terren/Gremlin.Net.CosmosDb/blob/94e1fe861aa9d0429b937d41a4a4e0a287d30730/src/Gremlin.Net.CosmosDb/Structure/GraphResult.cs#L91].
In general, I'm open to a better method to indicate that deserialization should
be skipped. However, this is most likely a breaking change and therefore has to
wait for 3.5.0.
> Special case for JToken in SubmitAsync()
> ----------------------------------------
>
> Key: TINKERPOP-2253
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2253
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
> Affects Versions: 3.4.0
> Reporter: Sam Hard
> Priority: Major
>
> A recent change to Gremlin.Net, made to address TINKERPOP-2067, broke
> existing functionality for the downstream library Gremlin.Net.CosmosDb. That
> library invokes Gremlin.Net.Driver.Connection's `SubmitAsync<T>()` method,
> sending `JToken` as the generic type argument, and expects the query results
> to be run through `_graphSONReader.ToObject()`, but that step is now
> specifically skipped just for `JToken`.
> I propose that it would be better for Connection.SubmitAsync() to work the
> same for all types, as it did before, and that a new property in the class
> (or an optional method parameter) could be used to configure when the
> graphSON reader should be bypassed.
> The breaking change was merged with this pull request:
> [https://github.com/apache/tinkerpop/pull/972]
> As a cross-reference, the GitHub issue documenting the problem with
> Gremlin.Net.CosmosDb can be found here:
> [https://github.com/evo-terren/Gremlin.Net.CosmosDb/issues/49]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
