[
https://issues.apache.org/jira/browse/TINKERPOP-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892658#comment-16892658
]
ASF GitHub Bot commented on TINKERPOP-2246:
-------------------------------------------
spmallette commented on pull request #1168: TINKERPOP-2246 Use
ResponseHandlerContext to ensure single final response to client
URL: https://github.com/apache/tinkerpop/pull/1168
Merged from #1148 with deprecation included.
@divijvaidya if this looks good to you, then i will move forward with
getting it merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Consolidate the error propagation to the client
> -----------------------------------------------
>
> Key: TINKERPOP-2246
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2246
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.2
> Reporter: Divij Vaidya
> Priority: Minor
>
> Some places in the code base use the ResponseHandlerContext which ensures
> that only a single response is sent for a particular request [1] but other
> places do not [2]. This task is to use the ResponseContext consistently
> across the code base to prevent cases where client gets two messages for the
> same request (this can break the client when it has removed the RequestQueue
> thinking that the query is complete and yet a message comes for that request
> queue).
> [1]
> [https://github.com/apache/tinkerpop/blob/d1a3fa147d1f009ae57274827c9b59426dfc6e58/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java#L100]
> [[2]
> https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java#L315|https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java#L315]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
