[
https://issues.apache.org/jira/browse/TINKERPOP-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911336#comment-16911336
]
stephen mallette commented on TINKERPOP-2286:
---------------------------------------------
I don't think the behavior should be to error out as many graphs that return
{{false}} for {{willAllowId()}} are doing that because they don't support id
assignment at all in which case the {{Attachable}} behavior makes sense to try
to {{addVertex()}} without specifying the {{id}}. Offhand i'm not sure of the
implications of changing that logic. I guess if you wanted an exception you
could get one by throwing an exception from your implementation of
{{willAllowId()}}, but that wouldn't be typical TinkerPop system behavior and
I'm not sure what sorts of unexpected behaviors you'd get as a result of doing
so.
> ID type support bug causing regression when loading data
> --------------------------------------------------------
>
> Key: TINKERPOP-2286
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2286
> Project: TinkerPop
> Issue Type: Bug
> Components: structure
> Affects Versions: 3.4.3
> Environment: Linux
> Reporter: Xin Wei
> Priority: Blocker
>
> Our provider version only supports string id, however when loading data with
> numeric ids via g.io().read().iterate() the DB didn't error out, but assigned
> random ids to those vertices with numeric ids, causing regression.
> The cause is :
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/Graph.java#L803]
>
> The allowId() method returns false when supportsStringIds() returns true and
> id is not instance of string.
> Then this method:
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/Attachable.java#L291]
> will not pass id into Graph.addVertex() method, making underlying method
> assign internal ids to the vertex, causing regression between the data we
> load and the data we store in the DB.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
