[
https://issues.apache.org/jira/browse/TINKERPOP-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928443#comment-16928443
]
stephen mallette commented on TINKERPOP-2205:
---------------------------------------------
> Can you also please remind me the specific issues which prevented us from
> merging this PR into master? Is that the flaky tests?
Given my comments on the original PR it seems like the issue was failing tests
as noted by Travis:
https://api.travis-ci.org/v3/job/545093810/log.txt
We also agreed we wanted the newer netty release in play with some of the fixes
you've alluded to - not sure if these were all of them:
https://github.com/netty/netty/pull/9116
https://github.com/netty/netty/pull/9226
Assuming we get a series of good clean builds across a few environments I can't
recall anything else standing in the way of this.
> What is the best way to run integ tests during development right now?
I just do {{mvn clean install && mvn verify -pl gremlin-server
-DskipIntegrationTests=false}} for a general fresh/run build but we'll want to
be sure we get clean {{docker/build.sh -t -i -n}} as well.
Thanks for coming back to this.
> Use one connection per request for Java client
> ----------------------------------------------
>
> Key: TINKERPOP-2205
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2205
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.3.6
> Reporter: Divij Vaidya
> Priority: Major
> Labels: deprecation
>
> This issue is a tracking item for the conversation in the mailing list
> [[1]|https://lists.apache.org/thread.html/77728cb77d4eab90f15680595e653ffc6055b74db29cbd4dcd5f0339@%3Cdev.tinkerpop.apache.org%3E]
> which highlights multiple problems and shortcomings in the existing Java
> client and proposes a design change in the client connection pooling to
> address the same. More specifically, the problems addressed are as follows:
> # Difficulty in configuring the client for optimum performance.
> # Undocumented dependency of configuration parameters on each other.
> # A bad request can impact other requests on the same channel.
> # Host is marked as dead even if it is busy serving requests.
> # No way to free up server resources if the client has stopped consuming
> results.
> # No differentiation between retriable and non-retriable exceptions from the
> application code.
> # Keep alive is only sent when a query is executing, which means that a
> connection open for a very long time with no query being sent will be closed
> by the server.
> # Race condition if the server response reaches before result queue has been
> registered.
> # Unpredictable behaviour if the server sends an exception followed by a
> genuine response for the same request.
> # A concurrent hash map (tracking pending requests) is a point of contention
> amongst threads.
> [1]https://lists.apache.org/thread.html/77728cb77d4eab90f15680595e653ffc6055b74db29cbd4dcd5f0339@%3Cdev.tinkerpop.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
