[
https://issues.apache.org/jira/browse/TINKERPOP-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964046#comment-16964046
]
ASF GitHub Bot commented on TINKERPOP-2309:
-------------------------------------------
spmallette commented on pull request #1212: TINKERPOP-2309 Bump to Tornado 5.x
URL: https://github.com/apache/tinkerpop/pull/1212
https://issues.apache.org/jira/browse/TINKERPOP-2309
Removed a test that started failing after the version bump. I assume it no
longer is necessary given that the error is "Cannot run the event loop while
another loop is running" and I've taken to mean that since asyncio is
automatically use when available the test is no longer relevant.
I'm not sure if other work should be done as a result of this upgrade. I
came across this comment on ipython while researching the test error I was
receiving:
https://github.com/jupyter/notebook/issues/3397#issuecomment-519283894
Not sure I know enough at this time about tornado/asyncio to know what
should be done to improve our implementation. If anyone cares to comment or
help by making a PR, it would be appreciated.
Builds with `mvn clean install -pl gremlin-python`.
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Bump gremlinpython to Tornado 5.x
> ---------------------------------
>
> Key: TINKERPOP-2309
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2309
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.3.9
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
>
> There's been some discussion on gremlin-users on upgrade to Tornado 6.0:
> https://groups.google.com/d/msg/gremlin-users/iT7o7XO0NOg/9CoZAbAYDAAJ
> We can't really do that while we support Python 2.x still. We can however try
> to go to Tornado 5.x and see how that goes. We can look to go to 6.0 when we
> hopefully drop python 2.x support in 3.5.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
