> Will not because message is null. There there is silent error eating.

You're right. I should have looked taken a closer look.

> Could we just check that deserialized object is not null and throw exception.

Yes, I think that might be the best option as we expect the message to never be 
null. So, if for some reason is actually null, then we can throw an exception 
which will result in a call to `CloseConnectionBecauseOfFailureAsync` which 
closes the connection completely and notifies all existing response handlers 
about the exception.

@Haapsaari-Juha: I don't know if you want to incorporate these changes into 
your PR as you were the first to contribute a fix for this issue or if 
@dzmitry-lahoda should update his PR accordingly.

> property based testing for any other array passed

Could you explain a bit further what you mean by this? Do you want to add 
property based testing for the internal classes of the driver?


[ Full content available at: https://github.com/apache/tinkerpop/pull/1247 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to