I'm not sure about the value these tests add as they are basically just 
asserting how a JSON deserializer should treat edge cases, but OK, they could 
become useful when we try out the new .NET JSON serializer, so I'm also not 
against adding them.
Could you however please refactor the tests a bit if you want to add them to 
Gremlin.Net? Each test should only test a single case, should have a clear name 
that reflects what the expected behaviour is and it should ideally be split 
into the three phases _arrange_, _act_, and _assert_, separated by newlines 
(see for example [here](http://wiki.c2.com/?ArrangeActAssert) for a reference).
The 
[GremlinServerTests](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/test/Gremlin.Net.UnitTest/Driver/GremlinServerTests.cs#L29)
 also show this nicely.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1250 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to