Since I see an initial vote on this one, I'll just add a few administrative 
points in relation to the review:

1. a CHANGELOG entry would be nice though whoever merges this could simply add 
that in
2. This change targets `master` - should it target an earlier branch? I'd guess 
it should at least target `3.4-dev` but perhaps it should even go back to 
`3.3-dev`? Thoughts @FlorianHockmann ?
3. Not sure why travis didn't like the last build - I've restarted the .NET 
body of tests.
4. Finally, @dzmitry-lahoda would you mind cleaning up the commit history a 
bit. It seems like this is a simple enough change that all of your commits on 
this PR could be squashed into one now that the review/feedback work is all 
done.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1250 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to