[ 
https://issues.apache.org/jira/browse/TINKERPOP-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170981#comment-17170981
 ] 

ASF GitHub Bot commented on TINKERPOP-2394:
-------------------------------------------

spmallette commented on pull request #1305:
URL: https://github.com/apache/tinkerpop/pull/1305#issuecomment-668729128


   > I think that renaming generated DSL class to ___ may be a breaking change 
higher than reordering imports.
   
   sure and i was ok with that for 3.5.0. 
   
   > There can also be some corner case where overwrite of other classes or 
constants may be needed (for instance, if I have a constant public static 
String id = "ID" for a specific customer requirement, I would like to be able 
to use it and use T.id to get element ID).
   
   ok - maybe not letting Gremlin have the last word on what the imports are is 
ok. I will merge this as it is. thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Unable to use __ class of a custom DSL when passing a script even if this 
> class is imported
> -------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-2394
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2394
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: groovy
>    Affects Versions: 3.4.7
>            Reporter: Nicolas Trangosi
>            Priority: Minor
>
> Even if I import the a custom DSL __ class, I cannot use in script as the 
> CoreGremlinPlugin override it with the class 
> {{org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__}}
> {code:java}
> var manager = SingleGremlinScriptEngineManager.instance();
> manager.addPlugin(ImportGremlinPlugin.build()
>                               .classImports( __.class,)
>                               .create());
> GremlinScriptEngine engine = manager.getEngineByName("gremlin-groovy");
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to