[
https://issues.apache.org/jira/browse/TINKERPOP-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185814#comment-17185814
]
ASF GitHub Bot commented on TINKERPOP-2335:
-------------------------------------------
jorgebay commented on a change in pull request #1317:
URL: https://github.com/apache/tinkerpop/pull/1317#discussion_r478371429
##########
File path: gremlin-javascript/pom.xml
##########
@@ -29,10 +29,21 @@ limitations under the License.
<maven.test.skip>false</maven.test.skip>
<skipTests>${maven.test.skip}</skipTests>
<gremlin.server.dir>${project.parent.basedir}/gremlin-server</gremlin.server.dir>
+ <npm.version>6.14.6</npm.version>
+ <node.version>v10.22.0</node.version>
Review comment:
Good idea to extract it into a property.
##########
File path:
gremlin-javascript/src/main/javascript/gremlin-javascript/package.json
##########
@@ -40,4 +40,4 @@
"engines": {
"node": ">=6"
Review comment:
We should state `"node": ">= 10"` in the package.json
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Drop support for older GLV runtimes
> -----------------------------------
>
> Key: TINKERPOP-2335
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2335
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet, javascript, python
> Affects Versions: 3.5.0
> Reporter: Jorge Bay
> Priority: Major
> Fix For: 3.5.0
>
>
> As [discussed on the mailing
> list|https://lists.apache.org/thread.html/r25901cdb66b913b32b025970a6cd435eae87609e5c5af3c8a4ce630a%40%3Cdev.tinkerpop.apache.org%3E],
> we should take the opportunity of the new revision to drop support for EOL'd
> runtimes for javascript, python and .NET.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
