[
https://issues.apache.org/jira/browse/TINKERPOP-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202373#comment-17202373
]
ASF GitHub Bot commented on TINKERPOP-2364:
-------------------------------------------
spmallette opened a new pull request #1332:
URL: https://github.com/apache/tinkerpop/pull/1332
https://issues.apache.org/jira/browse/TINKERPOP-2364
Didn't really add any tests here as it was a small change and we don't
really test the `toString()` outputs all that much. Would have pushed this
change through as CTR but wanted to see if there were any concerns about
changing the output by any graph providers. I can't quite imagine why this
would mess anyone up but I'll leave this out here for the next few days to see
if anyone has concerns.
For comparison, here is the old output:
```text
gremlin> g.V().local(out().fold()).profile()
==>Traversal Metrics
Step Count
Traversers Time (ms) % Dur
=============================================================================================================
TinkerGraphStep(vertex,[]) 1
1 0.092 68.58
LocalStep([VertexStep(OUT,vertex), ProfileStep,... 1
1 0.042 31.42
VertexStep(OUT,vertex) 1
1 0.013
FoldStep 1
1 0.011
>TOTAL -
- 0.134 -
```
here is the new:
```text
gremlin> g.V().local(out().fold()).profile()
==>Traversal Metrics
Step Count
Traversers Time (ms) % Dur
=============================================================================================================
TinkerGraphStep(vertex,[]) 6
6 2.377 72.51
LocalStep([VertexStep(OUT,vertex), FoldStep]) 6
6 0.901 27.49
VertexStep(OUT,vertex) 6
6 0.444
FoldStep 6
6 0.133
>TOTAL -
- 3.278 -
```
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Injected ProfileStep should not be displayed in child traversals
> ----------------------------------------------------------------
>
> Key: TINKERPOP-2364
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2364
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.3.10
> Reporter: Stephen Mallette
> Priority: Minor
>
> I imagine that {{ProfileStep}} is visible in child traversals for
> {{profile()}} output because we simple {{toString()}} the parent step:
> {code}
> gremlin> g.V().local(out().fold()).profile()
> ==>Traversal Metrics
> Step Count
> Traversers Time (ms) % Dur
> =============================================================================================================
> TinkerGraphStep(vertex,[]) 1
> 1 0.092 68.58
> LocalStep([VertexStep(OUT,vertex), ProfileStep,... 1
> 1 0.042 31.42
> VertexStep(OUT,vertex) 1
> 1 0.013
> FoldStep 1
> 1 0.011
> >TOTAL -
> - 0.134 -
> {code}
> It would be nice if for purpose of the {{profile()}} output at least if that
> could be cleaned up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
