[jira] [Commented] (TINKERPOP-2425) Server closes HTTP connection for keepAlive as true

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/TINKERPOP-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203220#comment-17203220
 ] 

ASF GitHub Bot commented on TINKERPOP-2425:
-------------------------------------------

spmallette commented on a change in pull request #1333:
URL: https://github.com/apache/tinkerpop/pull/1333#discussion_r495926402



##########
File path: 
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpGremlinEndpointHandler.java
##########
@@ -82,19 +84,11 @@
 import java.util.stream.Stream;
 
 import static com.codahale.metrics.MetricRegistry.name;
-import static 
io.netty.handler.codec.http.HttpHeaderNames.ACCESS_CONTROL_ALLOW_ORIGIN;
-import static io.netty.handler.codec.http.HttpHeaderNames.CONNECTION;
-import static io.netty.handler.codec.http.HttpHeaderNames.CONTENT_LENGTH;
-import static io.netty.handler.codec.http.HttpHeaderNames.CONTENT_TYPE;
-import static io.netty.handler.codec.http.HttpHeaderNames.ORIGIN;
+import static io.netty.handler.codec.http.HttpHeaderNames.*;
 import static io.netty.handler.codec.http.HttpMethod.GET;
 import static io.netty.handler.codec.http.HttpMethod.POST;
-import static io.netty.handler.codec.http.HttpResponseStatus.BAD_REQUEST;
-import static io.netty.handler.codec.http.HttpResponseStatus.CONTINUE;
-import static 
io.netty.handler.codec.http.HttpResponseStatus.INTERNAL_SERVER_ERROR;
-import static 
io.netty.handler.codec.http.HttpResponseStatus.METHOD_NOT_ALLOWED;
-import static io.netty.handler.codec.http.HttpResponseStatus.NOT_FOUND;
-import static io.netty.handler.codec.http.HttpResponseStatus.OK;
+import static io.netty.handler.codec.http.HttpResponseStatus.*;

Review comment:
       your IDE got a little fancy with our imports 🙂 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Server closes HTTP connection for keepAlive as true
> ---------------------------------------------------
>
>                 Key: TINKERPOP-2425
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2425
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.0, 3.4.8
>            Reporter: Divij Vaidya
>            Priority: Minor
>
> *Current behaviour*
> In `HttpGremlinEndpointHandler` we close the connection when sending out an 
> error in the response even if keepAlive is set as true on the request. 
> *Expected behaviour*
> Respect the `keepAlive` flag on the request and do not close the HTTP 
> connection if it set to true.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)