[
https://issues.apache.org/jira/browse/TINKERPOP-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203234#comment-17203234
]
ASF GitHub Bot commented on TINKERPOP-2427:
-------------------------------------------
spmallette commented on pull request #1334:
URL: https://github.com/apache/tinkerpop/pull/1334#issuecomment-700007900
Glad you were able to improve this code. The
`ctx.fireChannelRead(frame.retain(2));` always bugged me. I'd recommend that
you merge to `master` and run tests before merging this as I think you will
find some conflict there
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify Netty reference counting
> ---------------------------------
>
> Key: TINKERPOP-2427
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2427
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.5.0, 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
>
> We have some incorrect configuration in the code such as:
> [https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketGremlinResponseDecoder.java#L59]
> (MessageToMessageDecoder automatically decreases the reference count).
> [https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java#L270]
> (SimpleChannelInboundHandler automatically decreases the reference count).
> which are fixed by hardcoding values such as:
> [https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketClientHandler.java#L89]
> This Jira will fix the reference counting correctly and eliminate the need
> for hardcoding.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
