[
https://issues.apache.org/jira/browse/TINKERPOP-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206110#comment-17206110
]
ASF GitHub Bot commented on TINKERPOP-2430:
-------------------------------------------
spmallette commented on pull request #1336:
URL: https://github.com/apache/tinkerpop/pull/1336#issuecomment-702676775
Thanks for this documentation update - it's nice to get new recipes.
You might want to change the target branch to 3.4-dev so that this recipe
gets published with the next release otherwise it will have to wait until 3.5.0
which probably won't be in the next release round. It's fine if you don't, I
can bring it to 3.4-dev myself on merge.
The loop section is good - I would add a link from the `repeat()` and
`loops()` steps in the `the-traversal.asciidoc` to the recipe. At the bottom of
each is an "Additional References" section. Right now they all link to javadocs
but I think it would help bring some notice to "Recipes" if we linked from
there to relevant/related recipes. I would name the link as "Recipes - Looping"
and add them after all the javadoc.
Other than that, VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Looping Recipies
> ----------------
>
> Key: TINKERPOP-2430
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2430
> Project: TinkerPop
> Issue Type: Improvement
> Components: documentation
> Reporter: Dave Bechberger
> Priority: Minor
>
> Create documentation recipes for common looping patterns including:
> Conditional Looping with Max Depth
> Emitting the Loop Depth
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
