[
https://issues.apache.org/jira/browse/TINKERPOP-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237584#comment-17237584
]
ASF GitHub Bot commented on TINKERPOP-2468:
-------------------------------------------
divijvaidya commented on a change in pull request #1365:
URL: https://github.com/apache/tinkerpop/pull/1365#discussion_r528910198
##########
File path:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
##########
@@ -612,40 +612,42 @@ public void shouldProcessRequestsOutOfOrder() throws
Exception {
}
}
+ /**
+ * This test validates that the session requests are processed in-order on
the server. The order of results
+ * returned to the client might be different though since each result is
handled by a different executor thread.
+ */
Review comment:
Yes. Client side threads. More specifically, in
[this](https://github.com/apache/tinkerpop/pull/1347/files#diff-1a4243209a3c0c168ac7e9817b3bca1a2791db382c294130ea85c6f0bcec120cR109)
PR we made a change to remove the possibility of blocking the executor loop on
client by the application code by passing completion of readComplete future to
client's executor threads. For two different requests they might get assigned
to different threads in executor pool here and return results at different time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Stabilize shouldProcessSessionRequestsInOrder() test
> ----------------------------------------------------
>
> Key: TINKERPOP-2468
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2468
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.8
> Reporter: Stephen Mallette
> Assignee: Divij Vaidya
> Priority: Minor
>
> This test has been failing somewhat randomly on Travis lately:
> {code}
> [ERROR]
> shouldProcessSessionRequestsInOrder(org.apache.tinkerpop.gremlin.server.GremlinDriverIntegrateTest)
> Time elapsed: 9.593 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: iterable containing ["five", "zero"]
> but: item 0: was "zero"
> at
> org.apache.tinkerpop.gremlin.server.GremlinDriverIntegrateTest.shouldProcessSessionRequestsInOrder(GremlinDriverIntegrateTest.java:621)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
