[ 
https://issues.apache.org/jira/browse/TINKERPOP-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239275#comment-17239275
 ] 

ASF GitHub Bot commented on TINKERPOP-2445:
-------------------------------------------

spmallette commented on a change in pull request #1360:
URL: https://github.com/apache/tinkerpop/pull/1360#discussion_r531031219



##########
File path: pom.xml
##########
@@ -721,6 +722,18 @@ limitations under the License.
                     </exclusion>
                 </exclusions>
             </dependency>
+            <dependency>

Review comment:
       build failures on `master` are due to powermock incompatibility with 
java 11 and our upgrade on the mockito version. not sure how you want to best 
resolve those - i tried a couple quick things but couldn't get it working 
immediately:
   
   https://stackoverflow.com/questions/52966897/powermock-java-11
   
https://stackoverflow.com/questions/62305373/how-to-use-powermock-with-mockito3-x
   
   I sense it is something that can be resolved though, but i'll leave it to 
you at this point. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Speed up client initialization
> ------------------------------
>
>                 Key: TINKERPOP-2445
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2445
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver
>    Affects Versions: 3.5.0, 3.4.8
>            Reporter: Divij Vaidya
>            Priority: Minor
>              Labels: breaking
>         Attachments: screenshot-1.png
>
>
> The current Java client has a lot of initialization overhead. Some of the 
> things we could do to trim the fat are:
> 1. Parallelize the connection creation inside a connection pool, i.e. make 
> [this for 
> loop|https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java]
>  parallel. 
>  2. Do not create a bootstrap [for every 
> connection|https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Connection.java#L111].
>  A single bootstrap could be reused.
> 3. Remove SASL Handler from the pipeline after negotiation is complete for a 
> connection.
> 4. Do not initialize SASL Handler if not required.
> As part of this task, we should profile the start-up time and identify other 
> places where we could optimize the start-up time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to