[
https://issues.apache.org/jira/browse/TINKERPOP-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248172#comment-17248172
]
ASF GitHub Bot commented on TINKERPOP-2438:
-------------------------------------------
spmallette opened a new pull request #1371:
URL: https://github.com/apache/tinkerpop/pull/1371
https://issues.apache.org/jira/browse/TINKERPOP-2438
Even though TINKERPOP-2438 is already done this is a bit of a follow on to
that change. The GremlinScriptChecker performs the same exact task as the
GremlinAstChecker but it does so with regex parsing which should be faster than
processing a full AST. I've left the GremlinASTChecker where it is because I
wonder if there isn't yet some usage for more rigorous sort of checks we might
come up with in the future or perhaps have checks that only work well with AST
processing. It can be removed in the future if we like.
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Provide a way for scripts to respect with() specification of timeout
> --------------------------------------------------------------------
>
> Key: TINKERPOP-2438
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2438
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.8
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
> Fix For: 3.5.0, 3.4.9
>
>
> This issue sorta relates to the Gremlin Console but I think it's generally a
> server side problem as it could easily occur with HTTP or just scripts sent
> over web sockets. Folks tend to see all the ways they can set timeouts and
> then mix/match them. It only remains a problem with sending a script as
> {{g.with("evalTimeout",100)}} because the server won't know that this value
> was set until the script is passed to {{eval()}} but by then it's too late
> because we would have already started the timeout countdown. While most
> users wouldn't send that as a bare script submission it's a common mistake in
> the Gremlin Console and similar environments where it is not clear you are
> working with a remote graph.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
