[
https://issues.apache.org/jira/browse/TINKERPOP-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251663#comment-17251663
]
ASF GitHub Bot commented on TINKERPOP-2472:
-------------------------------------------
FlorianHockmann commented on pull request #1369:
URL: https://github.com/apache/tinkerpop/pull/1369#issuecomment-748005380
> are there any documentation changes necessary for this particular change
or is it largely transparent to the user when they upgrade?
It is transparent to users unless they want to use GraphSON 2 or if they for
some reason want to skip deserialization completely, but apart from the
ExRam.Gremlinq library I don't know why people would do that and the feature to
skip deserialization was also never communicated openly.
Configuration for GraphSON 2 changed from this:
```c#
var client = new GremlinClient(new GremlinServer("localhost", 8182), new
GraphSON2Reader(),
new GraphSON2Writer(), GremlinClient.GraphSON2MimeType);
```
to this:
```c#
var client = new GremlinClient(new GremlinServer("localhost", 8182), new
GraphSON2MessageSerializer());
```
which can be seen in the `GremlinVariantsTests` that are automatically
included in the reference docs. I think this is also a nice little improvement
for the API as users now only need to change a single parameter to change the
GraphSON version instead of three.
I didn't put that into the upgrade docs as the old `GremlinClient`
constructor is still there. I just deprecated it and point users to the new
constructor.
Should I still put this also in the upgrade docs? I'm always unsure what
kind of change is significant enough to warrant an entry there as I also don't
want to clutter it with information that is irrelevant for probably >99% of our
users.
Adding GraphBinary will of course make it more important for users how they
can change the serialization format, but I would then just add another part to
the reference docs where we already explain how to configure the client for
GraphSON 2. That would of course then also deserve a section in the upgrade
docs, just like [when we added it for
Python](https://tinkerpop.apache.org/docs/3.4.9-SNAPSHOT/upgrade/#_python_graphbinary).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GraphBinary support in .NET
> ---------------------------
>
> Key: TINKERPOP-2472
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2472
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.4.8
> Reporter: Florian Hockmann
> Priority: Major
>
> Support GraphBinary in Gremlin.Net.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
