[ 
https://issues.apache.org/jira/browse/TINKERPOP-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257042#comment-17257042
 ] 

ASF GitHub Bot commented on TINKERPOP-2473:
-------------------------------------------

vtslab commented on pull request #1376:
URL: https://github.com/apache/tinkerpop/pull/1376#issuecomment-752995413


   Nice to have this clarified. Only had time for a quick read. I believe you 
chose "new instance replaces old one" (from the changed code comments). This 
choice could be added to the changelog for clarity. The traversal ref docs have 
a section on Traversal Strategies that still describe the old behaviour. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Prevent TraversalStrategy instances of the same type to be added to a 
> TraversalSource
> -------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-2473
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2473
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.4.8
>            Reporter: Stephen Mallette
>            Priority: Major
>
> Not sure if this is a great idea but it came up as part of TINKERPOP-2389 
> where there might be a need to assign both a client-side and server-side 
> {{SubgraphStrategy}}. Currently, while not explicit, you can't assign more 
> than one strategy of a particular type using {{withStrategies()}}. This task 
> would make that explicit and provide a direct way for mergeable strategies to 
> be pushed together into one. If we did that it would also simplify 
> {{OptionsStrategy}} usage in {{with()}} step which currently finds an 
> existing one first if present and then adds to it (otherwise creates it new). 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to