[
https://issues.apache.org/jira/browse/TINKERPOP-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302352#comment-17302352
]
ASF GitHub Bot commented on TINKERPOP-2531:
-------------------------------------------
FlorianHockmann commented on pull request #1404:
URL: https://github.com/apache/tinkerpop/pull/1404#issuecomment-800094696
The tests look good and your latest modification to the pool also makes
sense to me.
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Gremlin .NET driver ConnectionPool can remain without connections if server
> is down for 1-2 minutes
> ---------------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2531
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2531
> Project: TinkerPop
> Issue Type: Bug
> Affects Versions: 3.4.10
> Reporter: Radu Iviniciu
> Priority: Major
>
> We are using Gremlin .NET client to connect to AWS Neptune.
> If the server is down for even just 1 - 2 minutes (E,.g. Instance reboot)
> the connection pool can remain without any healthy connections permanently
> even after the server comes back up again.
> Tracked this down to here:
> https://github.com/apache/tinkerpop/blob/60bfc90ce43567d609b1165989c1c74ce825109b/gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs#L154
> If the server was not ready yet and the connections were not restored as part
> of the previous TryGetAvailableConnection then the connection pool will
> remain empty indefinitely and all connections are dead even after the server
> is back up.
> Is this longer-ish downtime a use case the client should handle ? Or is it
> expected behavior and we should let the caller handle the
> ServerUnavailableException, potentially recreate the GremClient altogether ?
> What do you guys think ? If this is something the client should handle I can
> take a stab at it and put up a PR.
> Thank you.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
