[ https://issues.apache.org/jira/browse/TINKERPOP-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314974#comment-17314974 ]
ASF GitHub Bot commented on TINKERPOP-2245: ------------------------------------------- spmallette opened a new pull request #1414: URL: https://github.com/apache/tinkerpop/pull/1414 https://issues.apache.org/jira/browse/TINKERPOP-2245 The `UnifiedChannelizer` converges the thread pools used by sessions and sessionless requests while also streamlining the processing model for scripts and bytecode. There is a fair bit of explanation and discussion in the dev list thread linked in the JIRA. We will keep the old channelizers as the defaults for now, but the `UnifiedChannelizer` is meant to be the future and will eventually become the default allowing us to remove the `OpProcessor` infrastructure as well as the old channelizers in general. VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Consolidate the executor for bytecode & string based client > ----------------------------------------------------------- > > Key: TINKERPOP-2245 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2245 > Project: TinkerPop > Issue Type: Improvement > Components: server > Affects Versions: 3.4.2 > Reporter: Divij Vaidya > Assignee: Stephen Mallette > Priority: Minor > > We have two code paths in the server which perform (more or less) the same > functions. One is the executor for string based queries and other is the > executor for bytecode. This code can be refactored together so that the logic > to handle timeout, handle exception during execution, handle exception before > execution and others can consolidated. > [https://github.com/apache/tinkerpop/blob/master/gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/engine/GremlinExecutor.java#L246] > and > [https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java#L333] -- This message was sent by Atlassian Jira (v8.3.4#803005)