[
https://issues.apache.org/jira/browse/TINKERPOP-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319493#comment-17319493
]
ASF GitHub Bot commented on TINKERPOP-2245:
-------------------------------------------
spmallette commented on a change in pull request #1414:
URL: https://github.com/apache/tinkerpop/pull/1414#discussion_r611702053
##########
File path:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/Settings.java
##########
@@ -196,6 +198,59 @@ public Settings() {
*/
public String graphManager = DefaultGraphManager.class.getName();
+ /**
+ * Maximum size the general processing queue can grow before starting to
reject requests. The general processing
+ * queue is managed by a thread pool that has its size determined by
{@link #gremlinPool}. All incoming requests
+ * will be processed by this thread pool. If the threads are exhausted,
the requests will queue to the size
+ * specified by this value after which they will begin to reject the
requests.
+ * <p/>
+ * This value should be taken in account with the {@link
#maxSessionTaskQueueSize} which is related in some
+ * respects. A request that starts a new {@link Session} is handled by
this queue, but additional requests to a
+ * created {@link Session} will queue separately given that setting per
session.
+ * <p/>
+ * By default this value is set to 8192.
+ */
+ public int maxWorkQueueSize = 8192;
+
+ /**
+ * Maximum size that an individual {@link Session} can queue requests
before starting to reject them. Note that this
+ * configuration only applies to the {@link UnifiedChannelizer}. By
default this value is set to 4096.
+ *
+ * @see #maxWorkQueueSize
+ */
+ public int maxSessionTaskQueueSize = 4096;
+
+ /**
+ * Maximum number of parameters that can be passed on a request. Larger
numbers may impact performance for scripts.
+ * The default is 16 and this setting only applies to the {@link
UnifiedChannelizer}.
+ */
+ public int maxParameters = 16;
+
+ /**
+ * The time in milliseconds that a {@link UnifiedChannelizer} session can
exist. This value cannot be extended
+ * beyond this value irrespective of the number of requests and their
individual timeouts. Requests must complete
+ * within this time frame. The default is 10 minutes.
Review comment:
good idea - that will needed further clarification.
##########
File path:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/Settings.java
##########
@@ -196,6 +198,59 @@ public Settings() {
*/
public String graphManager = DefaultGraphManager.class.getName();
+ /**
+ * Maximum size the general processing queue can grow before starting to
reject requests. The general processing
+ * queue is managed by a thread pool that has its size determined by
{@link #gremlinPool}. All incoming requests
+ * will be processed by this thread pool. If the threads are exhausted,
the requests will queue to the size
+ * specified by this value after which they will begin to reject the
requests.
+ * <p/>
+ * This value should be taken in account with the {@link
#maxSessionTaskQueueSize} which is related in some
+ * respects. A request that starts a new {@link Session} is handled by
this queue, but additional requests to a
+ * created {@link Session} will queue separately given that setting per
session.
+ * <p/>
+ * By default this value is set to 8192.
+ */
+ public int maxWorkQueueSize = 8192;
+
+ /**
+ * Maximum size that an individual {@link Session} can queue requests
before starting to reject them. Note that this
+ * configuration only applies to the {@link UnifiedChannelizer}. By
default this value is set to 4096.
+ *
+ * @see #maxWorkQueueSize
+ */
+ public int maxSessionTaskQueueSize = 4096;
+
+ /**
+ * Maximum number of parameters that can be passed on a request. Larger
numbers may impact performance for scripts.
+ * The default is 16 and this setting only applies to the {@link
UnifiedChannelizer}.
+ */
+ public int maxParameters = 16;
+
+ /**
+ * The time in milliseconds that a {@link UnifiedChannelizer} session can
exist. This value cannot be extended
+ * beyond this value irrespective of the number of requests and their
individual timeouts. Requests must complete
+ * within this time frame. The default is 10 minutes.
Review comment:
good idea - that needed further clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Consolidate the executor for bytecode & string based client
> -----------------------------------------------------------
>
> Key: TINKERPOP-2245
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2245
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.2
> Reporter: Divij Vaidya
> Assignee: Stephen Mallette
> Priority: Minor
>
> We have two code paths in the server which perform (more or less) the same
> functions. One is the executor for string based queries and other is the
> executor for bytecode. This code can be refactored together so that the logic
> to handle timeout, handle exception during execution, handle exception before
> execution and others can consolidated.
> [https://github.com/apache/tinkerpop/blob/master/gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/engine/GremlinExecutor.java#L246]
> and
> [https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java#L333]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
