[
https://issues.apache.org/jira/browse/TINKERPOP-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344119#comment-17344119
]
Luz commented on TINKERPOP-2565:
--------------------------------
Thanks for validating this so quickly.
But I dont have much time to go through all the hassle.
It doesn't seem to be complicated to fix.
Anyway, it's not urgent for me and nobody else apparently as this went through
unnoticed for 7 years.
Have a nice day
> GraphMLWriter does not check vertexLabelKey conflict
> ----------------------------------------------------
>
> Key: TINKERPOP-2565
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2565
> Project: TinkerPop
> Issue Type: Bug
> Components: io
> Affects Versions: 3.4.11
> Reporter: Luz
> Priority: Minor
>
> Reading the GraphMLWriter code I came across [these weird lines of
> code|https://github.com/apache/tinkerpop/blob/74a492c043c64db33bb5a12a2dc6eaea253b3684/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java#L175]:
> {code:java}
> if (identifiedEdgeKeyTypes.containsKey(this.edgeLabelKey))
> throw new IllegalStateException(String.format("The edgeLabelKey value
> of[%s] conflicts with the name of an existing property key to be included in
> the GraphML", this.edgeLabelKey));
> if (identifiedEdgeKeyTypes.containsKey(this.edgeLabelKey))
> throw new IllegalStateException(String.format("The vertexLabelKey value
> of[%s] conflicts with the name of an existing property key to be included in
> the GraphML", this.vertexLabelKey));
> {code}
> The check is identical, but the exception is different?
> This smells like a copy-paste errors and the second check should be more
> like:
> {code:java}
> if (identifiedVertexKeyTypes.containsKey(this.vertexLabelKey))
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
