[
https://issues.apache.org/jira/browse/TINKERPOP-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355319#comment-17355319
]
ASF GitHub Bot commented on TINKERPOP-2551:
-------------------------------------------
OyvindSabo commented on a change in pull request #1424:
URL: https://github.com/apache/tinkerpop/pull/1424#discussion_r643437961
##########
File path: gremlint/package.json
##########
@@ -1,6 +1,6 @@
{
"name": "gremlint",
- "version": "1.0.0",
+ "version": "3.5.1-alpha1",
Review comment:
I've never tried alpha versions before, so I'm not sure if this matters,
but all of the examples I find online have a dot between alpha and 1, i.e.
`"3.5.1-alpha.1"`
##########
File path: gremlint/pom.xml
##########
@@ -0,0 +1,214 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.tinkerpop</groupId>
+ <artifactId>tinkerpop</artifactId>
+ <version>3.5.1-SNAPSHOT</version>
+ </parent>
+ <artifactId>gremlint</artifactId>
+ <name>Apache TinkerPop :: Gremlin Javascript</name>
Review comment:
Should this still be `Apache TinkerPop :: Gremlin Javascript` or should
it be `Apache Tinkerpop :: Gremlint`?
I see Gremlin Javascript appearing twice when running `mvn clean install`
:sweat_smile:
```
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary for Apache TinkerPop 3.5.1-SNAPSHOT:
[INFO]
[INFO] Apache TinkerPop ................................... SUCCESS [ 6.504
s]
[INFO] Apache TinkerPop :: Gremlin Language ............... SUCCESS [ 17.347
s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [ 1.690
s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [ 52.991
s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [ 17.952
s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [02:22
min]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [02:18
min]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [ 38.995
s]
[INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [ 3.065
s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [02:35
min]
[INFO] Apache TinkerPop :: Gremlin Javascript ............. SUCCESS [ 38.260
s]
[INFO] Apache TinkerPop :: Gremlin Python ................. SUCCESS [ 0.122
s]
[INFO] Apache TinkerPop :: Gremlin.Net .................... SUCCESS [ 1.180
s]
[INFO] Apache TinkerPop :: Gremlin.Net - Source ........... SUCCESS [ 0.777
s]
[INFO] Apache TinkerPop :: Gremlin.Net - Tests ............ SUCCESS [ 0.081
s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [01:37
min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [01:57
min]
[INFO] Apache TinkerPop :: SPARQL Gremlin ................. SUCCESS [ 6.157
s]
[INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [ 22.271
s]
[INFO] Apache TinkerPop :: Gremlin Archetype .............. SUCCESS [ 0.069
s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ........ SUCCESS [ 6.024
s]
[INFO] Apache TinkerPop :: Archetype - Server ............. SUCCESS [ 10.965
s]
[INFO] Apache TinkerPop :: Archetype - DSL ................ SUCCESS [ 4.679
s]
[INFO] Apache TinkerPop :: Gremlin Tools .................. SUCCESS [ 0.318
s]
[INFO] Apache TinkerPop :: Gremlin Benchmark .............. SUCCESS [ 9.198
s]
[INFO] Apache TinkerPop :: Gremlin Coverage ............... SUCCESS [ 0.312
s]
[INFO] Apache TinkerPop :: Gremlin IO Test ................ SUCCESS [ 12.937
s]
[INFO] Apache TinkerPop :: Gremlin Javascript ............. SUCCESS [ 25.513
s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Setup scripts to publish Gremint to npm
> ---------------------------------------
>
> Key: TINKERPOP-2551
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2551
> Project: TinkerPop
> Issue Type: Improvement
> Components: gremlint
> Affects Versions: 3.5.0
> Reporter: Øyvind Sæbø
> Priority: Major
>
> Currently The gremlint web app at tinkerpop.apache.org/gremlint still
> installs the gremlint library from github:OyvindSabo/gremlint#master. In the
> tinkerpop repo, however, gremlint is not located in the root directory, so
> installing it as a package directly from GitHub with npm is as far as I know
> not possible.
> It would be nice to get gremlint published to npm so that it's easier for
> users to use it in JavaScript projects, and so that the gremlint web app can
> use the latest code from tinkerpop/gremlint, rather than installing the no
> longer maintained code from OyvindSabo/gremlint.
> I assume this will have to be done similarly to how it's done for
> gremlin-javascript, although I haven't had time to look closely at how that's
> done yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
