[
https://issues.apache.org/jira/browse/TINKERPOP-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355857#comment-17355857
]
Øyvind Sæbø commented on TINKERPOP-2574:
----------------------------------------
Thanks(y)
> Don't gitignore package-lock.json
> ---------------------------------
>
> Key: TINKERPOP-2574
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2574
> Project: TinkerPop
> Issue Type: Improvement
> Components: gremlint, javascript
> Affects Versions: 3.4.11
> Reporter: Øyvind Sæbø
> Assignee: Øyvind Sæbø
> Priority: Trivial
> Fix For: 3.5.0, 3.3.11, 3.4.11
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Creating this task as a follow-up to
> https://issues.apache.org/jira/browse/TINKERPOP-2572.
> To make sure the result of running npm install is deterministic,
> package-lock.json should be committed along with package.json instead of
> being gitignored. This will prevent older package-lock.json files that may
> exist locally from earlier installs from being used to determine what
> versions to install when running npm install.
> I'm not 100% sure I understand how the Affects Version and Fix Version fields
> should be set when creating the Jira ticket. Feedback appreciated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
