Given how I read the comments on that PR there might be some confusion. Just to be clear that issue of TINKERPOP-2579 was marked as a blocker for release of 3.5.1, as in we wouldn't release without that being done and not that it blocked folks from using 3.5.0. The workaround for providers upgrading should be fine for release under 3.5.0, but EventStrategy users won't be able to use the 3.5.x line without a release of 3.5.1. So, I think that's the main issue here. I would have liked to have seen 3.5.1/3.4.12 bake a bit longer but i'm not against getting into a release discussion now as things are.
has JanusGraph tested against the 3.5.1-SNAPSHOT to be sure the fix resolves issues there at this point? the latest snapshot has been published with that fix at this point. i think that should be wholly confirmed before we actually go to code freeze - Oleksandr, is that something you can help do and report back on this thread? The benefit of releasing 3.5.1 now would also be to get the first release of gremlint out and put out javascript tx() support which should merge soon. I was hoping we'd get python in as well on 3.5.1 but if that has to wait for 3.5.2 that's fine I suppose. Ideally, we should get all variants running tx() by 3.5.2 and try to release that in the next couple of months or sooner. So releasing 3.5.1 now will mean we'll have a bit of a back to back release. Again, not bad, just something to consider. If we do go have consensus on a 3.5.1 release when would we start code freeze: 7/9 which if all went well would put release on July 26? Also, are there volunteers to handle release manager duties this time around (i can be around to assist, but i'd rather not be primary on this one)? As an aside, if we are going down this path, I wonder if we shouldn't canary a 3.5.1.alpha of gremlint to see how the deploy process works to npm...any concerns? On Thu, Jul 1, 2021 at 10:41 AM Oleksandr Porunov < [email protected]> wrote: > Hello, > > I would like to propose starting a release 3.5.1. > The main purpose for that is because it has an important bug fix: > https://issues.apache.org/jira/browse/TINKERPOP-2579 > This bug affects shipping JanusGraph 0.6.0 release as discussed here: > https://github.com/JanusGraph/janusgraph/pull/2672 > > Currently based on changelog I see that TinkerPop 3.5.1 version contains 2 > bugfixes and 2 improvements as well as all changes from 3.4.12 release. > > I believe that should be a good reason for the release. Hope to hear some > thoughts about it. > > Best regards, > Oleksandr Porunov >
