[ 
https://issues.apache.org/jira/browse/TINKERPOP-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387599#comment-17387599
 ] 

Stephen Mallette commented on TINKERPOP-2483:
---------------------------------------------

[~divijvaidya] Given the explained use case for this change related to custom 
auth scenarios, perhaps we can close this given TINKERPOP-2547 which satisfies 
that use case? or do we still need to do this?

> Make WebSocketChannelizer non-final in Java driver
> --------------------------------------------------
>
>                 Key: TINKERPOP-2483
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2483
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver
>    Affects Versions: 3.4.8
>            Reporter: Divij Vaidya
>            Priority: Minor
>
> With final keyword right now, it is not possible to extend 
> WebSocketChannelizer. This is an obstruction for providers who want to add 
> custom auth logic to the handlers. e.g. Amazon Neptune uses a fork of the 
> Channelizer to sign the HTTP request using sigv4 
> ([https://github.com/aws/amazon-neptune-gremlin-java-sigv4/blob/master/src/main/java/org/apache/tinkerpop/gremlin/driver/SigV4WebSocketChannelizer.java)]
>  
> This ticket proposes to allow WebSocketChannelizer to be extended.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to