[
https://issues.apache.org/jira/browse/TINKERPOP-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415506#comment-17415506
]
ASF GitHub Bot commented on TINKERPOP-2486:
-------------------------------------------
spmallette commented on pull request #1465:
URL: https://github.com/apache/tinkerpop/pull/1465#issuecomment-920009536
Travis is showing two job failures - I restarted one of them as i sense it
was unrelated, but the other specifically fails one of the new tests added here:
```text
[ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
68.217 s <<< FAILURE! - in
org.apache.tinkerpop.gremlin.driver.ClientConnectionIntegrateTest
[ERROR]
overLimitOperationsShouldDelegateToSingleNewConnection(org.apache.tinkerpop.gremlin.driver.ClientConnectionIntegrateTest)
Time elapsed: 31.629 s <<< ERROR!
java.lang.NullPointerException
at
org.apache.tinkerpop.gremlin.driver.ClientConnectionIntegrateTest.lambda$overLimitOperationsShouldDelegateToSingleNewConnection$6(ClientConnectionIntegrateTest.java:201)
at
org.apache.tinkerpop.gremlin.driver.ClientConnectionIntegrateTest.overLimitOperationsShouldDelegateToSingleNewConnection(ClientConnectionIntegrateTest.java:199)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Client does not load balance requests across available connections
> ------------------------------------------------------------------
>
> Key: TINKERPOP-2486
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2486
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
> Affects Versions: 3.4.8, 3.4.9
> Reporter: Divij Vaidya
> Priority: Major
>
> The client does not load balance requests across connections in a threadpool
> which cause a request failing with timeout even when a connection is
> available. To verify this, the following test fails:
> {code:java}
> @Test
> public void shouldBalanceConcurrentRequestsAcrossConnections() throws
> InterruptedException {
> final int connPoolSize = 16;
> final Cluster cluster = TestClientFactory.build()
> .minConnectionPoolSize(connPoolSize)
> .maxConnectionPoolSize(connPoolSize)
> .create();
> final Client.ClusteredClient client = cluster.connect();
> client.init();
> try {
> final RequestMessage.Builder request =
> client.buildMessage(RequestMessage.build(Tokens.OPS_EVAL))
> .add(Tokens.ARGS_GREMLIN, "Thread.sleep(5000)");
> final Callable<Connection> sendQueryCallable = () ->
> client.chooseConnection(request.create());
> final List<Callable<Connection>> listOfTasks = new ArrayList<>();
> for (int i=0; i<connPoolSize; i++) {
> listOfTasks.add(sendQueryCallable);
> }
> Set<String> channels = new HashSet<>();
> final List<Future<Connection>> executorSubmitFutures =
> executorServiceForTesting.invokeAll(listOfTasks);
> executorSubmitFutures.parallelStream().map(fut -> {
> try {
> return fut.get();
> } catch (InterruptedException e) {
> e.printStackTrace();
> } catch (ExecutionException e) {
> e.printStackTrace();
> }
> return null;
> }).forEach(conn -> channels.add(conn.getChannelId()));
>
> System.out.println(channels.size());
> } finally {
> cluster.close();
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
